-
Notifications
You must be signed in to change notification settings - Fork 364
feat: add solve-strategy to the manifest and solve
#4789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tdejager
merged 7 commits into
prefix-dev:main
from
bobozaur:feat/configurable-solve-strategy
Oct 26, 2025
Merged
feat: add solve-strategy to the manifest and solve
#4789
tdejager
merged 7 commits into
prefix-dev:main
from
bobozaur:feat/configurable-solve-strategy
Oct 26, 2025
+306
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b61540 to
ec9ae71
Compare
bobozaur
commented
Oct 20, 2025
bobozaur
commented
Oct 20, 2025
d703f4f to
0d46894
Compare
460c77b to
af043d8
Compare
tdejager
requested changes
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny nit :)
Makes `FeatureExt::solve_strategy` infallible and chooses the left-most feature's solve strategy when multiple features are defined.
fc88b34 to
87dbcab
Compare
|
I'm gonna give this a small user-test tomorrow and then it's good to go I think! |
|
Ok tested all of this out, and it works like expected and as a charm. Thank you for the contribution. |
tdejager
approved these changes
Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to set the strategy used in the solve. If the strategy is set by multiple features, the left-most one wins.
Closes #4753 .